eddy/Project_SylDa
Watch
1
1
Fork
You've already forked Project_SylDa
 0
Code Issues 2 Pull requests Projects Releases 3 Packages Wiki Activity Actions

fix: handle missing VERSION characteristic gracefully on old ESP firmware

Browse source
This commit is contained in:
eddy 2026-07-30 17:20:38 +02:00
commit 1499d840ce
1 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

10
android/app/src/main/java/nl/eddydevink/sylda/BleRelayManager.kt
View file

@ -286,8 +286,13 @@ class BleRelayManager(
val service = gatt.getService(SERVICE_UUID) val service = gatt.getService(SERVICE_UUID)
val versionChar = service?.getCharacteristic(VERSION_UUID) val versionChar = service?.getCharacteristic(VERSION_UUID)
if (versionChar != null) { if (versionChar != null) {
gatt.readCharacteristic(versionChar) val ok = gatt.readCharacteristic(versionChar)
if (!ok) {
Log.w(TAG, "readCharacteristic(VERSION) returned false, skipping version check")
handler.post { callbacks.onStatusChanged(BleStatus.Connected) }
}
} else { } else {
Log.d(TAG, "VERSION characteristic not found, skipping version check")
handler.post { callbacks.onStatusChanged(BleStatus.Connected) } handler.post { callbacks.onStatusChanged(BleStatus.Connected) }
} }
} else { } else {
@ -302,6 +307,9 @@ class BleRelayManager(
Log.d(TAG, "ESP firmware version: $version, app bundled: $appVersion") Log.d(TAG, "ESP firmware version: $version, app bundled: $appVersion")
handler.post { callbacks.onFirmwareVersion(version, appVersion) } handler.post { callbacks.onFirmwareVersion(version, appVersion) }
handler.post { callbacks.onStatusChanged(BleStatus.Connected) } handler.post { callbacks.onStatusChanged(BleStatus.Connected) }
} else if (characteristic.uuid == VERSION_UUID) {
Log.w(TAG, "Version read failed (status=$status), using Connected anyway")
handler.post { callbacks.onStatusChanged(BleStatus.Connected) }
} }
} }