eddy/Project_SylDa
Watch
1
1
Fork
You've already forked Project_SylDa
 0
Code Issues 2 Pull requests Projects Releases 3 Packages Wiki Activity Actions

fix: check writeCharacteristic return value in sendOtaData

Browse source
This commit is contained in:
eddy 2026-07-30 19:16:28 +02:00
commit 44297d30ad
2 changed files with 11 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
android/app/src/main/java/nl/eddydevink/sylda/BleRelayManager.kt
View file

@ -194,12 +194,12 @@ class BleRelayManager(
} }
@SuppressLint("MissingPermission") @SuppressLint("MissingPermission")
fun sendOtaData(data: ByteArray) { fun sendOtaData(data: ByteArray): Boolean {
val char = otaCharacteristic ?: return val char = otaCharacteristic ?: return false
val gatt = bluetoothGatt ?: return val gatt = bluetoothGatt ?: return false
char.value = data char.value = data
char.writeType = BluetoothGattCharacteristic.WRITE_TYPE_NO_RESPONSE char.writeType = BluetoothGattCharacteristic.WRITE_TYPE_NO_RESPONSE
gatt.writeCharacteristic(char) return gatt.writeCharacteristic(char)
} }
@SuppressLint("MissingPermission") @SuppressLint("MissingPermission")

8
android/app/src/main/java/nl/eddydevink/sylda/OtaManager.kt
View file

@ -105,7 +105,13 @@ class OtaManager(
var retries = 0 var retries = 0
while (retries < MAX_RETRIES) { while (retries < MAX_RETRIES) {
relayManager.sendOtaData(packet.array()) val writeOk = relayManager.sendOtaData(packet.array())
if (!writeOk) {
Log.w(TAG, "writeCharacteristic returned false for chunk $seq, retrying")
retries++
delay(100)
continue
}
Log.d(TAG, "Sent chunk $seq/$totalChunks ($chunkSize bytes) attempt ${retries + 1}") Log.d(TAG, "Sent chunk $seq/$totalChunks ($chunkSize bytes) attempt ${retries + 1}")
try { try {