From 68b15ce7f13b4854b6caf43dd66005f8055b09b5 Mon Sep 17 00:00:00 2001 From: eddy Date: Sun, 26 Jul 2026 16:23:55 +0200 Subject: [PATCH] Fix CDC line coding parity byte Change parity from 0x08 (SPACE) to 0x00 (NONE) to match 115200 8N1 specification. ESP32-S3 ignores this setting but the value was technically incorrect. Reviewed in codereview.md (recommendation #4). --- .../app/src/main/java/com/eddy/atomrelay/SettingsActivity.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/app/src/main/java/com/eddy/atomrelay/SettingsActivity.kt b/android/app/src/main/java/com/eddy/atomrelay/SettingsActivity.kt index db9d949..47b7166 100644 --- a/android/app/src/main/java/com/eddy/atomrelay/SettingsActivity.kt +++ b/android/app/src/main/java/com/eddy/atomrelay/SettingsActivity.kt @@ -427,7 +427,7 @@ class SettingsActivity : AppCompatActivity() { if (ctrlIntf != null && ctrlIntf.endpointCount > 0) { val lineCoding = byteArrayOf( 0x00.toByte(), 0xC2.toByte(), 0x01.toByte(), 0x00.toByte(), - 0x00.toByte(), 0x08.toByte(), 0x08.toByte() + 0x00.toByte(), 0x00.toByte(), 0x08.toByte() ) connection.controlTransfer(0x21, 0x20, 0, ctrlIntf.id, lineCoding, lineCoding.size, 500) connection.controlTransfer(0x21, 0x22, 3, ctrlIntf.id, null, 0, 500)