eddy/Project_SylDa
Watch
1
1
Fork
You've already forked Project_SylDa
 0
Code Issues 2 Pull requests Projects Releases 3 Packages Wiki Activity Actions

Refactor SettingsActivity (967 regels) naar aparte managers #17

New issue
Open
opened 2026-08-04 18:35:54 +02:00 by eddy · 0 comments
eddy commented 2026-08-04 18:35:54 +02:00
Owner
Copy link

Probleem:
SettingsActivity.kt bevat 967 regels en handelt:

  • Key exchange (USB CDC)
  • Firmware flashing
  • OTA updates
  • USB device detectie/reconnect
  • Theme management
  • Label editing
  • Dialog management

Voorstel:
Extract naar aparte klassen:

  • KeyExchangeManager — USB CDC key exchange
  • FirmwareFlasher — ESP32 flash via USB
  • UsbDeviceManager — USB device lifecycle, reconnect
  • ThemeHelper — theme switching (bestaat al gedeeltelijk in PrefsHelper)

Impact:
Verbeterde testbaarheid, leesbaarheid, en onderhoudbaarheid.

Labels: refactor, tech-debt, android
Prioriteit: medium

**Probleem:** `SettingsActivity.kt` bevat 967 regels en handelt: - Key exchange (USB CDC) - Firmware flashing - OTA updates - USB device detectie/reconnect - Theme management - Label editing - Dialog management **Voorstel:** Extract naar aparte klassen: - `KeyExchangeManager` — USB CDC key exchange - `FirmwareFlasher` — ESP32 flash via USB - `UsbDeviceManager` — USB device lifecycle, reconnect - `ThemeHelper` — theme switching (bestaat al gedeeltelijk in PrefsHelper) **Impact:** Verbeterde testbaarheid, leesbaarheid, en onderhoudbaarheid. **Labels:** refactor, tech-debt, android **Prioriteit:** medium
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
feature/client-ble-ota
v1.2
v1.1
v1.0
v2.0
Labels
Clear labels   
bug
Iets werkt niet correct

  
bug
Something isn't working

  
critical
Kritieke prioriteit

  
documentation
Documentatie

  
duplicate
This issue or pull request already exists

  
enhancement
Verbetering van bestaande functionaliteit

  
enhancement
New feature or request

  
feature
Nieuwe functionaliteit

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
security
Beveiligingsprobleem

  
wontfix
This will not be worked on

No labels
bug
bug
critical
documentation
duplicate
enhancement
enhancement
feature
good first issue
help wanted
invalid
question
security
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
eddy/Project_SylDa#17
No description provided.