eddy/Project_SylDa
Watch
1
1
Fork
You've already forked Project_SylDa
 0
Code Issues 2 Pull requests Projects Releases 3 Packages Wiki Activity Actions

fix: critical issues from code review #20

Merged
eddy merged 1 commit from fix/code-review-critical-issues into main 2026-08-04 18:44:55 +02:00
Conversation 0 Commits 1 Files changed 6 +22 -24
eddy commented 2026-08-04 18:37:13 +02:00
Owner
Copy link

Samenvatting

Fixes voor critical issues uit code review.

Critical fixes (4)

  1. README.md touch sensor — "actief HIGH" → "actief LOW", "geen pullup nodig" → "INPUT_PULLUP modus"
  2. README.md LED pin — G46 → G35 (WS2812 RGB)
  3. release.sh — kopieert nu server/ en client/ firmware (8 bestanden i.p.v. 4)
  4. Stale firmware.bin — verwijderd uit root assets

Important fixes (3)

  1. OtaManager.kt — 10s wachttijd na START → 500ms
  2. BleRelayManager.kt — bluetoothGatt?.close() voor nieuwe connect
  3. CompletableDeferred — custom class vervangen door kotlinx.coroutines.CompletableDeferred

Tests

  • ✅ Firmware build: beide environments succesvol
  • ✅ Versieconsistentie: alle 3 bestanden in sync (server=20, client=5)
## Samenvatting Fixes voor critical issues uit code review. ### Critical fixes (4) 1. **README.md touch sensor** — "actief HIGH" → "actief LOW", "geen pullup nodig" → "`INPUT_PULLUP` modus" 2. **README.md LED pin** — G46 → G35 (WS2812 RGB) 3. **release.sh** — kopieert nu `server/` en `client/` firmware (8 bestanden i.p.v. 4) 4. **Stale firmware.bin** — verwijderd uit root assets ### Important fixes (3) 5. **OtaManager.kt** — 10s wachttijd na START → 500ms 6. **BleRelayManager.kt** — `bluetoothGatt?.close()` voor nieuwe connect 7. **CompletableDeferred** — custom class vervangen door `kotlinx.coroutines.CompletableDeferred` ### Tests - ✅ Firmware build: beide environments succesvol - ✅ Versieconsistentie: alle 3 bestanden in sync (server=20, client=5)
fix: critical issues from code review
All checks were successful
CI / build (pull_request) Successful in 1m20s
Details
64ade7ff10 
- Fix README touch sensor docs (active LOW, INPUT_PULLUP)
- Fix README LED pin (G46 -> G35 WS2812)
- Fix release.sh to copy server/ and client/ firmware
- Remove stale firmware.bin from root assets
- Reduce OTA START wait from 10s to 500ms
- Close bluetoothGatt before new connection
- Use kotlinx.coroutines.CompletableDeferred
eddy merged commit 7829528e89 into main 2026-08-04 18:44:55 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Iets werkt niet correct

  
bug
Something isn't working

  
critical
Kritieke prioriteit

  
documentation
Documentatie

  
duplicate
This issue or pull request already exists

  
enhancement
Verbetering van bestaande functionaliteit

  
enhancement
New feature or request

  
feature
Nieuwe functionaliteit

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
security
Beveiligingsprobleem

  
wontfix
This will not be worked on

No labels
bug
bug
critical
documentation
duplicate
enhancement
enhancement
feature
good first issue
help wanted
invalid
question
security
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
eddy/Project_SylDa!20
No description provided.