fix: auto-detect upload port fails with active log output #24

Closed

eddy wants to merge 0 commits from fix/issue-16-auto-detect-port into main

eddy commented

2026-08-04 19:08:31 +02:00

Owner

Summary

Script-side: query_id() now filters for SylDa_Server or SylDa_Client instead of returning first non-empty line
Firmware-side: Added serial mute during ID? response to prevent log output interference
Cast CONFIG_LOG_DEFAULT_LEVEL to esp_log_level_t for type safety

Fixes #16

Test Plan

Connect both server and client via USB
Run pio run -e s3lite-client -t upload — should auto-detect client
Run pio run -e s3lite-server -t upload — should auto-detect server
Verify log output resumes after upload completes
Test during active ECDH handshake (worst case)

## Summary - Script-side: `query_id()` now filters for `SylDa_Server` or `SylDa_Client` instead of returning first non-empty line - Firmware-side: Added serial mute during `ID?` response to prevent log output interference - Cast `CONFIG_LOG_DEFAULT_LEVEL` to `esp_log_level_t` for type safety Fixes #16 ## Test Plan - [ ] Connect both server and client via USB - [ ] Run `pio run -e s3lite-client -t upload` — should auto-detect client - [ ] Run `pio run -e s3lite-server -t upload` — should auto-detect server - [ ] Verify log output resumes after upload completes - [ ] Test during active ECDH handshake (worst case)

eddy added 6 commits

2026-08-04 19:08:31 +02:00

docs: add design spec for issue #16 auto-detect port fix 30fc7532ae

docs: add implementation plan for issue #16 2030b42ba2

fix(script): filter ID response in query_id() 99fd6b21d4

fix(server): add serial mute during ID? response ae5028503f

fix(client): add serial mute during ID? response 3c6b378b9b

fix: cast CONFIG_LOG_DEFAULT_LEVEL to esp_log_level_t

CI / build (pull_request) Successful in 1m3s

Details

7b59d36bd7

eddy commented

2026-08-04 19:14:15 +02:00

Author

Owner

Test Results ✅

Alle hardware testen geslaagd:

Server ID? response: schoon SylDa_Server
Client ID? response: schoon SylDa_Client
Auto-detect client upload: ✅
Auto-detect server upload: ✅

De mute onderdrukt alle log output tijdens de ID? response. Script-side filtering vangt eventuele resterende log regels af.

## Test Results ✅ Alle hardware testen geslaagd: - Server ID? response: schoon `SylDa_Server` - Client ID? response: schoon `SylDa_Client` - Auto-detect client upload: ✅ - Auto-detect server upload: ✅ De mute onderdrukt alle log output tijdens de ID? response. Script-side filtering vangt eventuele resterende log regels af.

eddy referenced this pull request from a commit

2026-08-04 19:18:40 +02:00

Merge pull request 'fix: auto-detect upload port fails with active log output' (#24) from fix/issue-16-auto-detect-port into main

eddy closed this pull request

2026-08-04 19:35:55 +02:00

eddy referenced this pull request

2026-08-04 20:36:32 +02:00

Auto-detect upload port faalt bij client door serial log output #16