eddy/Project_SylDa
Watch
1
1
Fork
You've already forked Project_SylDa
 0
Code Issues 2 Pull requests Projects Releases 3 Packages Wiki Activity Actions

fix: HS-S43A touch migration + S3R cleanup (closes #5) #6

Closed
eddy wants to merge 0 commits from fix/issue-5-hs-s43a-s3r-cleanup into main
pull from: fix/issue-5-hs-s43a-s3r-cleanup
merge into: eddy:main
Conversation 1 Commits - Files changed -
eddy commented 2026-08-01 22:59:48 +02:00
Owner
Copy link

Summary

  • Remove INPUT_PULLUP, invert touch logic (LOW→HIGH) for HS-S43A sensors in both firmware files
  • Purge all obsolete "Atom S3R Voice" references from codebase (27 matches across docs, CI, tools)
  • Update board specs to M5Stack Atom S3 Lite
  • Fix CI/tools build paths: m5stack-atoms3r → s3lite-server

Test Plan

  • Both firmware environments compile SUCCESS (pio run)
  • Zero S3R references remaining (grep verified)
## Summary - Remove INPUT_PULLUP, invert touch logic (LOW→HIGH) for HS-S43A sensors in both firmware files - Purge all obsolete "Atom S3R Voice" references from codebase (27 matches across docs, CI, tools) - Update board specs to M5Stack Atom S3 Lite - Fix CI/tools build paths: m5stack-atoms3r → s3lite-server ## Test Plan - [x] Both firmware environments compile SUCCESS (`pio run`) - [x] Zero S3R references remaining (grep verified)
docs: purge remaining S3R references from historical docs and handleiding
All checks were successful
CI / firmware (pull_request) Successful in 1m20s
Details
CI / android (pull_request) Successful in 13s
Details
e5bb09e96e
eddy closed this pull request 2026-08-02 00:54:17 +02:00
eddy commented 2026-08-02 00:55:00 +02:00
Author
Owner
Copy link

Merged in 0bf2dcd. OTA-conflict resolved met HEAD (completere implementatie). Touch pin changes (INPUT_PULLUP → INPUT) behouden. Issue #5 gesloten.

Merged in 0bf2dcd. OTA-conflict resolved met HEAD (completere implementatie). Touch pin changes (INPUT_PULLUP → INPUT) behouden. Issue #5 gesloten.
All checks were successful
CI / firmware (pull_request) Successful in 1m20s
Details
CI / android (pull_request) Successful in 13s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Iets werkt niet correct

  
bug
Something isn't working

  
critical
Kritieke prioriteit

  
documentation
Documentatie

  
duplicate
This issue or pull request already exists

  
enhancement
Verbetering van bestaande functionaliteit

  
enhancement
New feature or request

  
feature
Nieuwe functionaliteit

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
security
Beveiligingsprobleem

  
wontfix
This will not be worked on

No labels
bug
bug
critical
documentation
duplicate
enhancement
enhancement
feature
good first issue
help wanted
invalid
question
security
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
eddy/Project_SylDa!6
No description provided.